pkgsStatic.curl: fix build#287515
Merged
mweinelt merged 2 commits intoNixOS:staging-nextfrom Feb 9, 2024
Merged
Conversation
Link: NixOS#285295 (comment) Fixes: 996b4eb ("curl: build with public suffix list support")
13 tasks
We need static curl for nixStatic, so we should test that it builds when changing curl. This would have caught a regression introduced by 996b4eb ("curl: build with public suffix list support").
ofborg
bot
added
10.rebuild-darwin: 0
vcunat
approved these changes
Feb 9, 2024
Member
vcunat
left a comment
vcunat
left a comment
There was a problem hiding this comment.
Looks OK, fixes the build for me and without rebuilding unnecessarily.
delroth
added
the
12.approvals: 1
mweinelt
approved these changes
Feb 9, 2024
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Link: #285295 (comment)
Fixes: 996b4eb ("curl: build with public suffix list support")
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.